Comments on: Useless use of if award http://ebergen.net/wordpress/2006/07/21/useless-use-of-if-award/ You will probably want some waders, a pickaxe, and one of those hats with a light on it before you go in here. Fri, 11 May 2012 07:02:34 +0000 hourly 1 http://wordpress.org/?v=3.3.2 By: Arno http://ebergen.net/wordpress/2006/07/21/useless-use-of-if-award/comment-page-1/#comment-2976 Arno Sun, 23 Jul 2006 06:11:48 +0000 http://ebergen.net/wordpress/2006/07/21/useless-use-of-if-award/#comment-2976 While the PHP example is a valid one, I don't think that SUM(your_field ‘’) is a good one. It implies that a boolean type TRUE is always cast into an interger 1. Which is not always the case. I have seen boolean TRUE as 1, 255, -1, and just about any other 32bit value in different languages, versions, and compilers over time. Who says that MySQL (which I assume the SUM example was run on) does not change the boolean->int cast from 1->-1 in a next release? While the PHP example is a valid one, I don’t think that SUM(your_field ‘’) is a good one. It implies that a boolean type TRUE is always cast into an interger 1. Which is not always the case. I have seen boolean TRUE as 1, 255, -1, and just about any other 32bit value in different languages, versions, and compilers over time.

Who says that MySQL (which I assume the SUM example was run on) does not change the boolean->int cast from 1->-1 in a next release?

]]> By: Jan Pieter Kunst http://ebergen.net/wordpress/2006/07/21/useless-use-of-if-award/comment-page-1/#comment-2968 Jan Pieter Kunst Fri, 21 Jul 2006 21:18:11 +0000 http://ebergen.net/wordpress/2006/07/21/useless-use-of-if-award/#comment-2968 I don't like 'saving keystrokes' when writing code. That leads to the slippery slope of incomprehensible, write-only code. In fact, I never even use the ternary operator. I would write your PHP example like so: <blockquote> $str = 'foo'; if ($str == 'foo') { return TRUE; } else { return FALSE; } </blockquote> Uncool, isn't it? I don’t like ‘saving keystrokes’ when writing code. That leads to the slippery slope of incomprehensible, write-only code. In fact, I never even use the ternary operator. I would write your PHP example like so:

$str = ‘foo’;

if ($str == ‘foo’) {
return TRUE;
} else {
return FALSE;
}

Uncool, isn’t it?

]]> By: Christian Machmeier http://ebergen.net/wordpress/2006/07/21/useless-use-of-if-award/comment-page-1/#comment-2967 Christian Machmeier Fri, 21 Jul 2006 20:48:19 +0000 http://ebergen.net/wordpress/2006/07/21/useless-use-of-if-award/#comment-2967 WP snipped my function! :( function foo() { return true; } WP snipped my function! :(

function foo() {
return true;
}

]]> By: Christian Machmeier http://ebergen.net/wordpress/2006/07/21/useless-use-of-if-award/comment-page-1/#comment-2966 Christian Machmeier Fri, 21 Jul 2006 20:46:23 +0000 http://ebergen.net/wordpress/2006/07/21/useless-use-of-if-award/#comment-2966 Hm… I tried to optimize the function even more and after hard hours of profiling, I came up with: ;) Hm…

I tried to optimize the function even more and after hard hours of profiling, I came up with:

;)

]]>