mysql> create table log (log int);
Query OK, 0 rows affected (0.00 sec)

mysql> insert into log set log=10;
Query OK, 1 row affected (0.00 sec)

mysql> create table error (error int);
Query OK, 0 rows affected (0.00 sec)

mysql> insert into error set error=1;
Query OK, 1 row affected (0.00 sec)

mysql> select error from error;
+——-+
| error |
+——-+
| 1 |
+——-+
1 row in set (0.00 sec)

mysql> select log from log;
+——+
| log |
+——+
| 10 |
+——+
1 row in set (0.00 sec)

May be something like..

FLUSH LOGS //All logs
FLUSH LOGS=0 //All logs
FLUSH LOGS=1 //General log
FLUSH LOGS=2 //Slow log
…

But that does not sound right though…

Thats a great patch..thanks for sharing.

Also, last year I made a patch will actually rotates the LOGS only at fixed 8K; and flush logs will simply ignore if the size is not met; and that size is configurable.

Great work. However, I notice in the patch that you are adding a number of new keywords: ERROR, GENERAL, LOG, SLOW, etc…

Have you checked to ensure that existing fields named as keywords do not break with your patch? Since things like ERROR and LOG could be common field names, I can envision a test is needed for this…

Also, before submitting the patch for inclusion (if you want to do that…) you will want to go through the code and ensure it meets the coding guidelines. Notably, assignment operators have no space between the variable name and the equals sign, and one space afterwards. In the patch, you use a variety of different styles (var=something; var = something;, etc…)

Anyway, other than that, the patch looks great.

Cheers,

Jay

Will you also include the complementary “purge…to….” commands for the individual logs?

May not really be related, but it would be great if logging could be enabled/disabled via dynamic global variables rather than having to restart mysqld.